(PC-31471) test: add assert_num_queries in public #13820
Conversation
blbpro
force-pushed
the
PC-31471_assert_num_queries_in_public
branch
from
5208bc4
to
53e1b20
Compare
mageoffray
force-pushed
the
PC-31471_assert_num_queries_in_public
branch
3 times, most recently
from
7c2f4bb
to
81c51b7
Compare
api/tests/routes/public/individual_offers/v1/get_offerer_venue_test.py
Outdated
Show resolved
Hide resolved
| num_queries += 1 # select stock | ||
| num_queries += 1 # select venue | ||
| with testing.assert_num_queries(num_queries): | ||
| response = client.with_basic_auth(pro_user.email).get(url) |
There was a problem hiding this comment.
Attention à pro_user.email, n'est-ce pas la raison de la première requête ?
There was a problem hiding this comment.
Ça ma étonné aussi mais non, je l'ai quand même sorti du assert_num_queries pour que visuellement on soit sûr qu'il n'ajoute pas de requête
api/tests/routes/public/booking_token/v2/get_booking_by_token_v2_test.py
Outdated
Show resolved
Hide resolved
api/tests/routes/public/booking_token/v2/get_booking_by_token_v2_test.py
Show resolved
Hide resolved
mageoffray
force-pushed
the
PC-31471_assert_num_queries_in_public
branch
3 times, most recently
from
d84c4a4
to
c38798f
Compare
There was a problem hiding this comment.
Quel est exactement le but recherché pour les assert_num_queries ?
Il me semble qu'il serait préférable de ne pas appliquer les assert_num_queries à tout les tests d'un endpoint parce que ça complexifie la lecture du test.
Je serais plutôt partisan d'avoir pour chaque endpoint un test dédié aux assert_num_queries sur un certain nombre de cas nominaux (200, 400, 404, 401) qui s'appellerait quelque chose comme test_num_queries. Ça permettrait d'alléger les autres tests qui s'occupent de tester la logique métier et de les rendre plus clairs. Ainsi si jamais ma modification a changé le nombre query, il n'y aurait qu'un test rouge et qu'un test à fixer (ça allègerait la PR).
api/tests/routes/public/booking_token/v2/get_booking_by_token_v2_test.py
Show resolved
Hide resolved
api/tests/routes/public/collective/endpoints/get_collective_offers_categories_test.py
Show resolved
Hide resolved
api/tests/routes/public/collective/endpoints/get_collective_offers_categories_test.py
Outdated
Show resolved
Hide resolved
api/tests/routes/public/collective/endpoints/get_collective_offers_educational_domains_test.py
Outdated
Show resolved
Hide resolved
api/tests/routes/public/collective/endpoints/get_collective_offers_test.py
Outdated
Show resolved
Hide resolved
api/tests/routes/public/collective/endpoints/get_educational_institutions_test.py
Outdated
Show resolved
Hide resolved
api/tests/routes/public/collective/endpoints/get_educational_institutions_test.py
Outdated
Show resolved
Hide resolved
api/tests/routes/public/collective/endpoints/get_list_subcategories_test.py
Show resolved
Hide resolved
api/tests/routes/public/individual_offers/v1/get_event_categories_test.py
Show resolved
Hide resolved
mageoffray
force-pushed
the
PC-31471_assert_num_queries_in_public
branch
4 times, most recently
from
3d7bed0
to
b14b32a
Compare
mageoffray
force-pushed
the
PC-31471_assert_num_queries_in_public
branch
from
b14b32a
to
ffc4d7b
Compare
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31471